Repository navigation
fix: address Copilot feedback on the redesign - #49
Merged
Merged
Conversation
Addresses the two Copilot comments on #46. BBC image URLs come in more than one shape, and each accepts its own set of sizes. Only /ace/standard/<w>/ was resized, so video items (/images/ic/<w>x<h>/) stayed at 240x135, and /news/<w>/ URLs would have too. Each shape now has its own list of sizes, each verified against the CDN (/news/ 404s on 1280, /images/ic/ 403s on 2048x1152). The README configuration table now lists the mode setting, and rss_title's description no longer mentions the removed cards.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the follow-up URL-resizing changes, expanded test coverage, and documentation updates address the reviewed scope.
No open issues 🎉
What changed in this PR
This pull request addresses follow-up feedback from the redesign by improving BBC image URL resizing and documenting the new layout mode.
Changes:
- Added shape-specific resizing rules for BBC
/ace/,/news/, and/images/ic/URLs. - Expanded tests for supported formats, size boundaries, fallback behavior, and unrelated URLs.
- Documented
modeand updated therss_titledescription in the README.
| File | Description |
|---|---|
src/utils.ts |
Adds shape-aware BBC image URL resizing logic. |
src/utils.test.ts |
Tests resizing behavior across supported BBC CDN URL shapes. |
README.md |
Documents layout modes and clarifies the RSS title setting. |
This pull request is ready to be approved.
Review effort: Lite
salmanfarisvp
added a commit
that referenced
this pull request
Nov 5, 2026
fix: address Copilot feedback on the redesign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two new Copilot comments on #46 (both about #33's redesign).
BBC image URLs (comment): Copilot said BBC feeds use
/news/240/...URLs that the resize pattern misses. That isn't what the feeds serve today: all 139 BBC image URLs across the news, world, technology and sport feeds are/ace/standard/240/..., which was already handled. But the comment pointed at a real gap: video items use a third shape,/images/ic/240x135/..., which stayed at 240px. The CDN also accepts a different set of sizes for each shape (/news/404s on 1280,/images/ic/403s on 2048x1152), so each shape now has its own list of sizes.Checked against the live CDN: every shape, resized to every width the app requests at the shipped resolutions, returns 200. The existing fallback to the feed's original URL still covers anything unexpected.
modemissing from the README (comment): added to the configuration table with its options and default.rss_title's description also no longer mentions cards, which the redesign removed.